[ENH] BEP 020 Eye Tracking #1128
Conversation
correction of text
|
(NOTE: I'll cross-post this message across several BEP threads) Hi there, just a quick notification that we have just merged #918 and it may be interesting to look at the implications for this BEP. We are introducing "BIDS URIs", which unify the way we refer to and point to files in BIDS datasets (as opposed to "dataset-relative" or "subject-relative" or "file-relative" links). If the diff and discussion in the PR is unclear, you can also read the rendered version: https://bids-specification.readthedocs.io/en/latest/02-common-principles.html#bids-uri Perhaps there are things in the BEP that need adjusting now, but perhaps also not -- in any case it's good to be aware of this new feature! Let me know if there are any questions, comments, or concerns. |
effigies
dismissed stale reviews from Remi-Gau, tsalo, and julia-pfarr
Outdated
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
Some more foreignindexcolumns
Co-authored-by: Julia-Katharina Pfarr <[email protected]>
|
I have opened mszinte#12 to address the two comments in @yarikoptic's review. It is easily addressed in the schema with no validator changes necessary. @gbezold1 @julia-pfarr @mszinte Would you have a look? |
Co-authored-by: Yaroslav Halchenko <[email protected]>
…into gaze-on-screen
yarikoptic
left a comment
yarikoptic
left a comment
There was a problem hiding this comment.
some clarifications needed as spotted during quick review
| Description of gaze-mapping settings. | ||
| For example, threshold on pupil confidence required for gaze mapping. |
There was a problem hiding this comment.
"Description" suggests a text field but it is an object. But then it talks about items like in an array (of types object). I didn't find any other case like that in the schema and not sure if it is legit. @effigies might be able to help clarifying this for me.
If it is to be a dictionary (object) of some settings, may be some could at least recommend naming (in description) on some of those fields names?
There was a problem hiding this comment.
the same seems to apply to many other fields!
Note also that there is no example for GazeMappingSettings in the text, which again, leaves reader with a question on what it should contain and in what form.
| name: RecordedEye | ||
| display_name: Recorded Eye | ||
| description: | | ||
| Indicates the eye tracked, for example, `"left"` or `"right"`. |
There was a problem hiding this comment.
It seems that there was an agreement on consistent use of "eye-tracking" hence I think:
| Indicates the eye tracked, for example, `"left"` or `"right"`. | |
| Indicates the eye-tracked, for example, `"left"` or `"right"`. |
There was a problem hiding this comment.
and adjust title of the PR (will get into changelog right?)
26 participants
Important
This BEP is under community review from September 29 - October 10, 2025. Please participate at #2218.
Tip
HTML preview of this BEP
Here is the specifications of the BEP 020 about eye tracking.
Note
We meet regularly and everyone is welcome :
Next meeting April 3rd 2025 4pm UTC (EST 11am, PST 8am, CET 5pm, GMT 4pm) on zoom.
Note that if you consider joining but this time or day doesn't suits you, reach me (@mszinte) and I will arrange another appointment.
Notes of last meeting
Chat and discussions also happening on matrix
Issues for: